linux-kernel - Re: [PATCH tip/core/rcu 28/48] net: Make accesses to ->br

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100504142631.148b52dc@nehalam>
Date:	Tue, 4 May 2010 14:26:31 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com,
	dipankar@...ibm.com, akpm@...ux-foundation.org,
	mathieu.desnoyers@...ymtl.ca, josh@...htriplett.org,
	dvhltc@...ibm.com, niv@...ibm.com, tglx@...utronix.de,
	peterz@...radead.org, rostedt@...dmis.org, Valdis.Kletnieks@...edu,
	dhowells@...hat.com, eric.dumazet@...il.com,
	Arnd Bergmann <arnd@...db.de>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH tip/core/rcu 28/48] net: Make accesses to ->br_port safe
 for sparse RCU

On Tue,  4 May 2010 13:19:38 -0700
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> wrote:

> The new versions of the rcu_dereference() APIs requires that any pointers
> passed to one of these APIs be fully defined.  The ->br_port field
> in struct net_device points to a struct net_bridge_port, which is an
> incomplete type.  This commit therefore changes ->br_port to be a void*,
> and introduces a br_port() helper function to convert the type to struct
> net_bridge_port, and applies this new helper function where required.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Cc: David Miller <davem@...emloft.net>
> Cc: Stephen Hemminger <shemminger@...ux-foundation.org>
> Cc: Eric Dumazet <eric.dumazet@...il.com>

I would rather make the bridge hook generic and not take a type argument.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/