linux-kernel - Re: [PATCH -next] staging/cxt1e1: Convert bare printks to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 May 2010 14:21:14 +0200
From:	Peter Hüwe <PeterHuewe@....de>
To:	devel@...uxdriverproject.org
Cc:	Joe Perches <joe@...ches.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	devel@...verdev.osuosl.org,
	Stephen Rothwell <sfr@...b.auug.org.au>, gregkh@...e.de,
	support@...i.com, LKML <linux-kernel@...r.kernel.org>,
	linux-next@...r.kernel.org, support@...stopsystems.com
Subject: Re: [PATCH -next] staging/cxt1e1: Convert bare printks to pr_<level>

Am Montag 03 Mai 2010 21:33:16 schrieb Joe Perches:
> Added #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> A few line splits for long arguments
> A couple of embedded function names converted to "%s", __func__
> Removed some uses of THIS_MODULE->name
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Hi, 
I applied Joe's patch, but unfortunately it misses out one part of Randy's 
original patch, i.e. the conversion in line 286 of hwprobe.c.

Joe: Can you perhaps add this to your patch?

Thanks, 
Peter

Signed-off-by: Peter Huewe <peterhuewe@....de>
---
Copied from original Patch by Randy dunlap

--- linux-next-20100503.orig/drivers/staging/cxt1e1/hwprobe.c
+++ linux-next-20100503/drivers/staging/cxt1e1/hwprobe.c
@@ -282,7 +283,7 @@ c4_hdw_init (struct pci_dev * pdev, int 
          */
         char       *cp = hi->devname;
 
-        strcpy (cp, THIS_MODULE->name);
+        strcpy (cp, KBUILD_MODNAME);
         cp += strlen (cp);          /* reposition */
         *cp++ = '-';
         *cp++ = '0' + (found / 2);  /* there are two found interfaces per





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/