linux-kernel - Re: [PATCH tip/core/rcu 36/48] nfs: _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 May 2010 14:01:21 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Trond Myklebust <Trond.Myklebust@...app.com>
Cc:	David Howells <dhowells@...hat.com>, linux-kernel@...r.kernel.org,
	mingo@...e.hu, laijs@...fujitsu.com, dipankar@...ibm.com,
	akpm@...ux-foundation.org, mathieu.desnoyers@...ymtl.ca,
	josh@...htriplett.org, dvhltc@...ibm.com, niv@...ibm.com,
	tglx@...utronix.de, peterz@...radead.org, rostedt@...dmis.org,
	Valdis.Kletnieks@...edu, eric.dumazet@...il.com,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH tip/core/rcu 36/48] nfs: __rcu annotations

On Wed, May 05, 2010 at 08:44:55AM -0400, Trond Myklebust wrote:
> On Wed, 2010-05-05 at 11:14 +0100, David Howells wrote: 
> > Paul E. McKenney <paulmck@...ux.vnet.ibm.com> wrote:
> > 
> > >  struct nfs_delegation {
> > >  	struct list_head super_list;
> > > -	struct rpc_cred *cred;
> > > +	struct rpc_cred __rcu *cred;
> > >  	struct inode *inode;
> > >  	nfs4_stateid stateid;
> > >  	fmode_t type;
> > 
> > That's unnecessary.  I posted a patch that removed the usage of RCU on that
> > pointer:
> > 
> > 	Date: Tue, 20 Apr 2010 11:26:13 +0100
> > 	Subject: NFS: Fix RCU issues in the NFSv4 delegation code
> > 
> > Did Trond take it?
> > 
> > David
> 
> Yes. I haven't pushed it to Linus yet, but I'm planning to do so in the
> next 2 days.

I have dropped this change from this commit.  Are the rest of the changes
in this commit (nfs_fs.h and auth_gss.h) OK?

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/