linux-kernel - Re: [PATCH] sysfs: Don't use enums in inline function declaration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 05 May 2010 15:05:59 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	ebiederm@...ssion.com
CC:	Greg KH <gregkh@...e.de>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] sysfs: Don't use enums in inline function declaration.

On 05/05/10 14:54, ebiederm@...ssion.com wrote:
> 
> It appears gcc can't cope with using an enum that is only declared in
> an inline function declaration, that doesn't even use the variable
> that is so declared.
> 
> Avoid the silliness and replace the enum with an int, and make gcc
> happy.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...stanetworks.com>

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

Thanks, Eric.

> ---
>  include/linux/sysfs.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> index e58ca1c..17cbeb7 100644
> --- a/include/linux/sysfs.h
> +++ b/include/linux/sysfs.h
> @@ -318,7 +318,7 @@ static inline void sysfs_put(struct sysfs_dirent *sd)
>  {
>  }
>  
> -static inline void sysfs_exit_ns(enum kobj_ns_type type, const void *tag)
> +static inline void sysfs_exit_ns(int type, const void *tag)
>  {
>  }
>  


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/