linux-kernel - Re: [PATCH] Parisc: Check kmalloc return value before use the buffer in ccio-dma.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100506105948.GV6747@parisc-linux.org>
Date:	Thu, 6 May 2010 04:59:48 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Kyle McMartin <kyle@...artin.ca>
Cc:	wzt.wzt@...il.com, linux-kernel@...r.kernel.org,
	linux-parisc@...r.kernel.org, deller@....de, jejb@...isc-linux.org
Subject: Re: [PATCH] Parisc: Check kmalloc return value before use the
	buffer in ccio-dma.c

On Thu, May 06, 2010 at 12:03:31AM -0400, Kyle McMartin wrote:
> We can change it to GFP_ATOMIC|__GFP_NOFAIL so it will retry infinitely,
> or we can panic in the error path with a nice error message so the users
> knows why his machine isn't going to work.

If we can't initialise the IOMMU, can we even get a panic message out to
the user?

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/