linux-kernel - Re: [PATCH 1/8] ipmi: Change addr_source to an enum rather than strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <4BE2F31E.5020201@acm.org>
Date:	Thu, 06 May 2010 11:49:34 -0500
From:	Corey Minyard <minyard@....org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	OpenIPMI Developers <openipmi-developer@...ts.sourceforge.net>,
	Matthew Garrett <mjg@...hat.com>,
	Myron Stowe <myron.stowe@...com>
Subject: Re: [PATCH 1/8] ipmi: Change addr_source to an enum rather than strings

Andrew Morton wrote:
> I already have three IPMI patches queued:
>
> http://userweb.kernel.org/~akpm/mmotm/broken-out/ipmi-raise-precedence-of-pnp-based-discovery-mechanisms-acpi-pci.patch
>   
I don't believe this patch is valid.  The discovery order in the patch 
from Matthew is the correct one, I believe.  So NACK on this one.

> http://userweb.kernel.org/~akpm/mmotm/broken-out/ipmi-convert-tracking-of-the-acpi-device-pointer-to-a-pnp-device.patch
>   
This should be good.

> http://userweb.kernel.org/~akpm/mmotm/broken-out/ipmi-update-driver-to-use-dev_printk-and-its-constructs.patch
>   
This is nice, I'll rework it and resend.

Thanks a bunch.

-corey

> The first two were repairable.  The third is now thoroughly trashed and
> needs redoing.
>
> I have no record of you having reviewed or [n]acked those three IPMI
> patches?
>
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/