linux-kernel - Re: indiscriminate get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 06 May 2010 13:52:28 -0700
From:	Joe Perches <joe@...ches.com>
To:	Davide Libenzi <davidel@...ilserver.org>
Cc:	Stefan Richter <stefanr@...6.in-berlin.de>,
	Changli Gao <xiaosuo@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: indiscriminate get_maintainer.pl usage

On Thu, 2010-05-06 at 10:59 -0700, Davide Libenzi wrote:
> > Right now, the default for # of git commits signed to be
> > added to the CC list is 1.  It's possible to change the default.
> >     --git-min-signatures => number of signatures required (default: 1)
> >     --git-max-maintainers => maximum maintainers to add (default: 5)
> >     --git-min-percent => minimum percentage of commits required (default: 5)
> > Maybe some fine-tuning of the defaults could be useful.
> > Suggestions?
> (not knowing the get_maintainers internals ...)
> Maybe if you weigh each contributor by the amount (in terms of diffstat 
> modulo) of changes, you can get more accurate results.

That might tend to overweight cleanup against actual logic patches,
especially as the period for commits tracked is defaulted to 1 year. 

> Part of the weight might be related to the time distance
> (relative to current time) since the changeset.

Which is kind of what activity alone does.

I think get_maintainer with --git (the default):

Without a named MAINTAINER:

For relatively active files: works moderately well.

For relatively inactive files: might work less well.

It tends to hide the original developer and show people
that submit cleanup or fix patches.

Maybe the --git portion could be reduce the number of
commit signers added when files have named MAINTAINERS.

Without named MAINTAINERS, maybe the file should be
inspected for author info and those persons added.

If the original commit is after Linus' first wholesale
commit of 2.6.12, maybe the first git author should be
added.

Dunno.  I think any of those might be slight improvements,
but get_maintainers isn't really that much of an issue
as-is.  I think it more important to get the correct
MAINTAINERS entries and file patterns.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/