linux-kernel - Re: [2.6.31.13] Build failure at arch/x86/kernel/apic/io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100506224429.GC7600@kroah.com>
Date:	Thu, 6 May 2010 15:44:29 -0700
From:	Greg KH <greg@...ah.com>
To:	Yinghai <yinghai.lu@...cle.com>
Cc:	Greg KH <gregkh@...e.de>,
	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	trenn@...e.de, hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: [2.6.31.13] Build failure at arch/x86/kernel/apic/io_apic.c

On Mon, May 03, 2010 at 10:50:41AM -0700, Yinghai wrote:
> On 05/03/2010 10:44 AM, Greg KH wrote:
> > On Mon, May 03, 2010 at 10:16:06AM -0700, Yinghai wrote:
> >> On 05/01/2010 11:07 AM, Greg KH wrote:
> >>> On Mon, Apr 12, 2010 at 01:10:59PM +0900, Tetsuo Handa wrote:
> >>>> Commit d539e5576605d048e6aeb21cbe3a8e71dc5eea81 "x86: Fix SCI on IOAPIC != 0"
> >>>> introduced "void setup_IO_APIC_irq_extra(u32 gsi)" which calls
> >>>> mp_find_ioapic() and mp_find_ioapic_pin().
> >>>>
> >>>> This commit does not compile if CONFIG_X86_IO_APIC=y and CONFIG_ACPI=n .
> >>>
> >>> Why would you want to build without ACPI on any modern system?  Anyway,
> >>> have a fix for this?
> >>>
> >> maybe just put #ifdef CONFIG_ACPI around the callee etc?
> > 
> > Ick.  How was it solved upstream?
> > 
> 
> those two functions are moved to arch/x86/kernel/apic/io_apic.c
> 
> maybe you can put that patch to 2.6.31.xx?

In looking at it further, that patch is just too big for .31 at this
point in time, sorry.  Just select ACPI as a config option, and you
should be fine.

Actually, use .32 or .33, I wouldn't recommend using .31 anymore anyway.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/