linux-kernel - Re: mmotm-2010-0428: swapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100506145758.84ff7199.nishimura@mxp.nes.nec.co.jp>
Date:	Thu, 6 May 2010 14:57:58 +0900
From:	Daisuke Nishimura <nishimura@....nes.nec.co.jp>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Daisuke Nishimura <nishimura@....nes.nec.co.jp>
Subject: Re: mmotm-2010-0428: swapper_space error

On Thu, 6 May 2010 13:42:48 +0900, Daisuke Nishimura <nishimura@....nes.nec.co.jp> wrote:
> sorry...
> 
> I'll re-check my build test script and prepare a patch as soon as possible.
> 
This is a fix for memcg-move-charge-of-file-pages.patch.

After this patch, it passed the build test for all the configs with possible
combinations of SWAP, SHMEM, MEM_RES_CTLR and MEM_RES_CTLR_SWAP.

===
From: Daisuke Nishimura <nishimura@....nes.nec.co.jp>

Build fix for !CONFIG_SWAP case.

mm/built-in.o: In function `mem_cgroup_get_shmem_target':
(.text+0xde06): undefined reference to `swapper_space'

Reported-by: Randy Dunlap <rdunlap@...otime.net>
Signed-off-by: Daisuke Nishimura <nishimura@....nes.nec.co.jp>
---
 mm/shmem.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index 6f183ef..6517bbd 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -2591,10 +2591,12 @@ void mem_cgroup_get_shmem_target(struct inode *inode, pgoff_t pgoff,
 
 	spin_lock(&info->lock);
 	ptr = shmem_swp_entry(info, pgoff, NULL);
+#ifdef CONFIG_SWAP
 	if (ptr && ptr->val) {
 		entry.val = ptr->val;
 		page = find_get_page(&swapper_space, entry.val);
 	} else
+#endif
 		page = find_get_page(inode->i_mapping, pgoff);
 	if (ptr)
 		shmem_swp_unmap(ptr);
-- 
1.6.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/