linux-kernel - Re: [PATCH 1/2] mm: remove unnecessary use of atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100506151813.b4e625d2.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Thu, 6 May 2010 15:18:13 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Phil Carmody <ext-phil.2.carmody@...ia.com>
Cc:	balbir@...ux.vnet.ibm.com, nishimura@....nes.nec.co.jp,
	akpm@...ux-foundation.org, kirill@...temov.name,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mm: remove unnecessary use of atomic

On Wed,  5 May 2010 14:21:48 +0300
Phil Carmody <ext-phil.2.carmody@...ia.com> wrote:

> From: Phil Carmody <ext-phil.2.carmody@...ia.com>
> 
> The bottom 4 hunks are atomically changing memory to which there
> are no aliases as it's freshly allocated, so there's no need to
> use atomic operations.
> 
> The other hunks are just atomic_read and atomic_set, and do not
> involve any read-modify-write. The use of atomic_{read,set}
> doesn't prevent a read/write or write/write race, so if a race
> were possible (I'm not saying one is), then it would still be
> there even with atomic_set.
> 
> See:
> http://digitalvampire.org/blog/index.php/2007/05/13/atomic-cargo-cults/
> 
> Signed-off-by: Phil Carmody <ext-phil.2.carmody@...ia.com>
> Acked-by: Kirill A. Shutemov <kirill@...temov.name>

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/