linux-kernel - Re: [PATCH] Check kmalloc return value before use the buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BE3E2AB.9030107@tuxonice.net>
Date:	Fri, 07 May 2010 19:51:39 +1000
From:	Nigel Cunningham <nigel@...onice.net>
To:	Steven Liu <lingjiujianke@...il.com>
CC:	Linus WALLEIJ <linus.walleij@...ricsson.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Check kmalloc return value before use the buffer

Hi.

On 07/05/10 19:47, Steven Liu wrote:
> Hi, guy,
>
> the code in arch/arm/mach-u300/dummyspichip.c is
>
>      bigtxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
>      if (bigtxbuf_virtual == NULL) {
>          status = -ENOMEM;
>          goto out;
>      }
>      bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
>
>
> if kmalloc memory space for bigrxbuf_virtual is NULL, when it have
> kmalloc DMA_TEST_SIZE memory space for bigtxbuf_virtual,so ,if kmalloc
> memory for bigtxbuf_virtual success and kmalloc memory for
> bigrxbuf_virtual faild,i think we must kfree  bigtxbuf_virtual memory

Ah, I see. I misread. Humble apologies :)

The other point still applies: You need to add a commit comment - even a 
simple one.

Regards,

Nigel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/