linux-kernel - Re: [PATCH 5/5] blk-cgroup: Fix an RCU warning in blkiocg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100507145515.GA2368@linux.vnet.ibm.com>
Date:	Fri, 7 May 2010 07:55:15 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	Li Zefan <lizf@...fujitsu.com>,
	"containers@...ts.osdl.org" <containers@...ts.osdl.org>,
	Paul Menage <menage@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Vivek Goyal <vgoyal@...hat.com>,
	Gui Jianfeng <GuiJianfeng@...fujitsu.com>
Subject: Re: [PATCH 5/5] blk-cgroup: Fix an RCU warning in blkiocg_create()

On Fri, May 07, 2010 at 08:57:41AM +0200, Jens Axboe wrote:
> On Fri, May 07 2010, Li Zefan wrote:
> > Paul E. McKenney wrote:
> > > On Thu, Apr 22, 2010 at 05:32:28PM +0800, Li Zefan wrote:
> > >> with CONFIG_PROVE_RCU=y, a warning can be triggered:
> > >>
> > >>   # mount -t cgroup -o blkio xxx /mnt
> > >>   # mkdir /mnt/subgroup
> > >>
> > >> ...
> > >> kernel/cgroup.c:4442 invoked rcu_dereference_check() without protection!
> > >> ...
> > >>
> > >> To fix this, we avoid caling css_depth() here, which is a bit simpler
> > >> than the original code.
> > > 
> > > Queued for 2.6.34, thank you!
> > > 
> > 
> > Seems neither you nor Jens queued this patch...
> 
> I've included it now, thanks.

<red face>  Thank you both for catching this one!!!

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/