linux-kernel - Re: [lm-sensors] [patch]hp_accel: Fix race in device removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201005071803.41668.oneukum@suse.de>
Date:	Fri, 7 May 2010 18:03:41 +0200
From:	Oliver Neukum <oneukum@...e.de>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Eric Piel <eric.piel@...mplin-utc.net>,
	Pavel Herrmann <morpheus.ibis@...il.com>,
	linux-kernel@...r.kernel.org, lm-sensors@...sensors.org,
	Pavel Machek <pavel@....cz>, stable@...nel.org
Subject: Re: [lm-sensors] [patch]hp_accel: Fix race in device removal

Am Freitag, 7. Mai 2010 17:54:01 schrieb Jean Delvare:
> Hi Oliver,
> 
> On Fri, 7 May 2010 17:47:40 +0200, Oliver Neukum wrote:
> > From 64a9e0d8e585c65526248e6cf1659a13fb01a93a Mon Sep 17 00:00:00 2001
> > From: Oliver Neukum <oliver@...kum.org>
> > Date: Fri, 7 May 2010 17:41:59 +0200
> > Subject: [PATCH] hp_accel: Fix race in device removal
> > 
> > The work queue has to be flushed after the device has been made
> > inaccessible.
> > 
> > Signed-off-by: Oliver Neukum <oneukum@...e.de>
> > ---
> >  drivers/hwmon/hp_accel.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c
> > index c8ab505..6f6e05d 100644
> > --- a/drivers/hwmon/hp_accel.c
> > +++ b/drivers/hwmon/hp_accel.c
> > @@ -328,9 +328,9 @@ static int lis3lv02d_remove(struct acpi_device *device, int type)
> >  	lis3lv02d_joystick_disable();
> >  	lis3lv02d_poweroff(&lis3_dev);
> >  
> > -	flush_work(&hpled_led.work);
> >  	led_classdev_unregister(&hpled_led.led_classdev);
> > -
> > +	flush_work(&hpled_led.work);
> > +	
> >  	return lis3lv02d_remove_fs(&lis3_dev);
> >  }
> >  
> 
> You are adding trailing white space. Please don't. Use
> scripts/checkpatch.pl to check your patches before you send them.

Thank you. A corrected version is on its way.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/