linux-kernel - Re: [PATCH] ad7877: fix spi word size to 16 bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 May 2010 14:23:07 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Daniel Glöckner <dg@...ix.com>
Cc:	Oskar Schirmer <os@...ix.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Oliver Schneidewind <osw@...ix.com>,
	Michael Hennerich <michael.hennerich@...log.com>
Subject: Re: [PATCH] ad7877: fix spi word size to 16 bit

On Fri, May 7, 2010 at 05:41, Daniel Glöckner wrote:
> On 05/06/2010 08:26 PM, Mike Frysinger wrote:
>> i think it'd be a better idea to do something like:
>>   if (spi->bits_per_word != 16) {
>>     if (spi->bits_per_word) {
>>       dev_err(&spi->dev, "Invalid SPI settings; bits_per_word must be 16\n");
>>       return -EINVAL;
>>     }
>>     spi->bits_per_word = 16;
>>     spi_setup(spi);
>>   }
>
> There is no way to set bits_per_word using struct spi_board_info. The
> description of that structure in spi.h explicitly lists the wordsize as
> one of the parameters drivers should set themself in probe().
>
> Only struct bfin5xx_spi_chip allows to set this value in the board code.

an obvious shortcoming in the SPI framework that should be fixed, but
that doesnt make any difference to the above code now does it ?  it'll
operate correctly regardless of the SPI bus master.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/