linux-kernel - [tip:perf/core] perf: Fix check at end of event search

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-d9f599e1e6d019968b35d2dc63074b9e8964fa69@git.kernel.org>
Date:	Fri, 7 May 2010 18:40:42 GMT
From:	tip-bot for Dan Carpenter <error27@...il.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	rostedt@...dmis.org, error27@...il.com, tglx@...utronix.de
Subject: [tip:perf/core] perf: Fix check at end of event search

Commit-ID:  d9f599e1e6d019968b35d2dc63074b9e8964fa69
Gitweb:     http://git.kernel.org/tip/d9f599e1e6d019968b35d2dc63074b9e8964fa69
Author:     Dan Carpenter <error27@...il.com>
AuthorDate: Sat, 20 Mar 2010 17:39:11 +0300
Committer:  Steven Rostedt <rostedt@...dmis.org>
CommitDate: Thu, 6 May 2010 19:49:52 -0400

perf: Fix check at end of event search

The original code doesn't work because "call" is never NULL there.

Signed-off-by: Dan Carpenter <error27@...il.com>
LKML-Reference: <20100320143911.GF5331@...ker>
Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
---
 kernel/trace/trace_events_filter.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index 88c0b6d..58092d8 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -1398,7 +1398,7 @@ int ftrace_profile_set_filter(struct perf_event *event, int event_id,
 	}
 
 	err = -EINVAL;
-	if (!call)
+	if (&call->list == &ftrace_events)
 		goto out_unlock;
 
 	err = -EEXIST;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/