linux-kernel - Re: [PATCH] mfd: WM8350: remove incorrect kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100509211029.GB3269@sortiz.org>
Date:	Sun, 9 May 2010 23:10:30 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Rabin Vincent <rabin@....in>
Cc:	broonie@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: WM8350: remove incorrect kfree

Hi Vincent,

On Wed, Apr 21, 2010 at 09:06:05PM +0530, Rabin Vincent wrote:
> The i2c_client received in probe() should not be kfree()'d.
Patch applied, many thanks.

Cheers,
Samuel.


> Signed-off-by: Rabin Vincent <rabin@....in>
> ---
>  drivers/mfd/wm8350-i2c.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/wm8350-i2c.c b/drivers/mfd/wm8350-i2c.c
> index 65830f5..5fe5de1 100644
> --- a/drivers/mfd/wm8350-i2c.c
> +++ b/drivers/mfd/wm8350-i2c.c
> @@ -64,10 +64,8 @@ static int wm8350_i2c_probe(struct i2c_client *i2c,
>  	int ret = 0;
>  
>  	wm8350 = kzalloc(sizeof(struct wm8350), GFP_KERNEL);
> -	if (wm8350 == NULL) {
> -		kfree(i2c);
> +	if (wm8350 == NULL)
>  		return -ENOMEM;
> -	}
>  
>  	i2c_set_clientdata(i2c, wm8350);
>  	wm8350->dev = &i2c->dev;
> -- 
> 1.7.0.4
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/