linux-kernel - Re: [PATCH] i2c-bfin-twi: handle faulty slave devices better

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 9 May 2010 14:23:58 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Ben Dooks <ben-linux@...ff.org>
Cc:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	uclinux-dist-devel@...ckfin.uclinux.org,
	Michael Hennerich <michael.hennerich@...log.com>
Subject: Re: [PATCH] i2c-bfin-twi: handle faulty slave devices better

On Sun, May 9, 2010 at 07:34, Ben Dooks wrote:
> On Sun, May 09, 2010 at 07:04:47AM -0400, Mike Frysinger wrote:
>> From: Michael Hennerich <michael.hennerich@...log.com>
>>
>> Faulty slave devices might drive SDA low after a transfer finishes.  So,
>> when this scenario is detected, have the master generate up to 8 extra
>> clocks until the SDA is properly released.
>>
>> Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>
>> Signed-off-by: Mike Frysinger <vapier@...too.org>
>> ---
>> Note: this requires the existing Blackfin TWI patches already sent out
>
> hmm, it is late in the -rc series for anything other than critical
> bugfixes, will update series tomorrow.

this patch is fine for 2.6.35, but the rest of the series should have
been merged for like 2.6.33 ...

>>  drivers/i2c/busses/i2c-bfin-twi.c |   22 ++++++++++++++++++++++
>>  1 files changed, 22 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c
>> index fb26e5c..f9c05e1 100644
>> --- a/drivers/i2c/busses/i2c-bfin-twi.c
>> +++ b/drivers/i2c/busses/i2c-bfin-twi.c
>> @@ -20,6 +20,7 @@
>>  #include <linux/completion.h>
>>  #include <linux/interrupt.h>
>>  #include <linux/platform_device.h>
>> +#include <linux/delay.h>
>>
>>  #include <asm/blackfin.h>
>>  #include <asm/portmux.h>
>> @@ -159,6 +160,27 @@ static void bfin_twi_handle_interrupt(struct bfin_twi_iface *iface,
>>               if (mast_stat & BUFWRERR)
>>                       dev_dbg(&iface->adap.dev, "Buffer Write Error\n");
>>
>> +             /* Faulty salve devices, may drive SDA low after a transfer
> spello: slave

ok, i'll resend in a bit
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/