linux-kernel - Re: [PATCH] perf_event: Make software events work again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1273478652.5605.3325.camel@twins>
Date:	Mon, 10 May 2010 10:04:12 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Paul Mackerras <paulus@...ba.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Lin Ming <ming.m.lin@...el.com>,
	Frederic Weisbecker <fweisbec@...il.com>, eranian@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf_event: Make software events work again

On Sat, 2010-05-08 at 20:58 +1000, Paul Mackerras wrote:
> Commit 6bde9b6ce0127e2a56228a2071536d422be31336 ("perf: Add group
> scheduling transactional APIs") added code to allow a group to be
> scheduled in a single transaction.  However, it introduced a bug in
> handling events whose pmu does not implement transactions -- at the
> end of scheduling in the events in the group, in the non-transactional
> case the code now falls through to the group_error label, and proceeds
> to unschedule all the events in the group and return failure.
> 
> This fixes it by returning 0 (success) in the non-transactional case.

D'0h I should have spotted that :/

Thanks Paul!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/