linux-kernel - Re: [tip:x86/cpu] Modify the VMware balloon driver for the new x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201005100106.07156.dtor@vmware.com>
Date:	Mon, 10 May 2010 01:06:06 -0700
From:	Dmitry Torokhov <dtor@...are.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	"mingo@...hat.com" <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"greg@...ah.com" <greg@...ah.com>,
	"hjanssen@...rosoft.com" <hjanssen@...rosoft.com>,
	"ksrinivasan@...ell.com" <ksrinivasan@...ell.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	Alok Kataria <akataria@...are.com>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/cpu] Modify the VMware balloon driver for the new x86_hyper API

On Sunday 09 May 2010 01:20:44 am H. Peter Anvin wrote:
> On 05/09/2010 01:19 AM, tip-bot for H. Peter Anvin wrote:
> >  MODULE_AUTHOR("VMware, Inc.");
> >  MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
> > 
> > @@ -767,7 +767,7 @@ static int __init vmballoon_init(void)
> > 
> >  	 * Check if we are running on VMware's hypervisor and bail out
> >  	 * if we are not.
> >  	 */
> > 
> > -	if (!vmware_platform())
> > +	if (x86_hyper != &x86_hyper_vmware)
> > 
> >  		return -ENODEV;
> >  	
> >  	vmballoon_wq = create_freezeable_workqueue("vmmemctl");
> 
> Note: I did not change the existing code, but this is an example of a
> very common bug: the appropriate error code for "hardware is not
> present" is ENXIO, not ENODEV.
>

Source please? I was not aware that there was a standard governing
returns code for module init methods.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/