linux-kernel - [BUGFIX] ACPI, APEI, Fix building of APEI EINJ and GHES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1273483482.3344.65.camel@yhuang-dev.sh.intel.com>
Date:	Mon, 10 May 2010 17:24:42 +0800
From:	Huang Ying <ying.huang@...el.com>
To:	Len Brown <lenb@...nel.org>, Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: [BUGFIX] ACPI, APEI, Fix building of APEI EINJ and GHES

Randy reported building warnings and errors for APEI EINJ and GHES as follow:

drivers/acpi/apei/einj.c:127:error: implicit declaration of function 'ndelay'

ghes.c:(.text+0x119e71): undefined reference to `apei_mce_report_mem_error'
CONFIG_X86_MCE is not enabled

This patch fixes these two bugs.

Reported-by: Randy Dunlap <randy.dunlap@...cle.com>
Signed-off-by: Huang Ying <ying.huang@...el.com>
---
 drivers/acpi/apei/einj.c |    1 +
 drivers/acpi/apei/ghes.c |    2 ++
 2 files changed, 3 insertions(+)

--- a/drivers/acpi/apei/einj.c
+++ b/drivers/acpi/apei/einj.c
@@ -29,6 +29,7 @@
 #include <linux/init.h>
 #include <linux/io.h>
 #include <linux/debugfs.h>
+#include <linux/delay.h>
 #include <linux/seq_file.h>
 #include <linux/nmi.h>
 #include <acpi/acpi.h>
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -242,6 +242,7 @@ static void ghes_do_proc(struct ghes *gh
 
 	ser = ghes_severity(ghes->estatus->error_severity);
 	apei_estatus_for_each_section(ghes->estatus, gdata) {
+#ifdef CONFIG_X86_MCE
 		if (!uuid_le_cmp(*(uuid_le *)gdata->section_type,
 				 CPER_SEC_PLATFORM_MEM)) {
 			apei_mce_report_mem_error(
@@ -249,6 +250,7 @@ static void ghes_do_proc(struct ghes *gh
 				(struct cper_sec_mem_err *)(gdata+1));
 			processed = 1;
 		}
+#endif
 	}
 
 	if (!processed && printk_ratelimit())


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/