linux-kernel - Re: [PATCH] Block: Check major number before allocate the buffer in register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100510115642.GB27497@kernel.dk>
Date:	Mon, 10 May 2010 13:56:42 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	wzt.wzt@...il.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Block: Check major number before allocate the buffer
	in register_blkdev()

On Mon, May 10 2010, wzt.wzt@...il.com wrote:
> Check major number before allocate the buffer, if the major number is not exist,
> and the register_blkdev() called many times, kmalloc()/kfree() will be no need 
> to invoked many times. So check the major number before use kmalloc() to allocate
> the buffer will be better.

This would generally be sound advice for performance oriented code, but
I can't see it making any difference here.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/