| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100510124353.GG6450@erda.amd.com> Date: Mon, 10 May 2010 14:43:53 +0200 From: Robert Richter <robert.richter@....com> To: Cyrill Gorcunov <gorcunov@...nvz.org> CC: "mingo@...e.hu" <mingo@...e.hu>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Peter Zijlstra <peterz@...radead.org>, Frederic Weisbecker <fweisbec@...il.com>, Lin Ming <ming.m.lin@...el.com> Subject: Re: [patch 1/4] x86,perf: P4 PMU -- configurate predefined events On 08.05.10 07:25:51, Cyrill Gorcunov wrote: > If an event is not RAW we should exit p4_hw_config > early but call x86_setup_perfctr as well. > > CC: Peter Zijlstra <peterz@...radead.org> > CC: Ingo Molnar <mingo@...e.hu> > CC: Frederic Weisbecker <fweisbec@...il.com> > CC: Lin Ming <ming.m.lin@...el.com> > CC: Robert Richter <robert.richter@....com> > Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org> > --- > > Robert, if only I'm not missing something this is > a side effect of commit 9d0fcba67e47ff398a6fa86476d4884d472dc98a, > wonders why don't we hit it earlier. Am I wrong? Yes, that's true, the function had have two exit points. Thanks for the fix. -Robert -- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter@....com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists