linux-kernel - Re: [PATCH] Staging: wlags49_h2: fixed C99 comments style issues in wl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <h2w2f9dd5d81005100952pebcd7beby549d1f7762f8e70f@mail.gmail.com>
Date:	Mon, 10 May 2010 22:22:16 +0530
From:	Prashant Shah <pshah.mumbai@...il.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	gregkh@...e.de, akpm@...ux-foundation.org, pe1dnn@...at.org,
	ext-andriy.shevchenko@...ia.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: wlags49_h2: fixed C99 comments style issues in 
	wl_profile.c

Hi,

>> -//     } else {
>> -//             this should not be debug time info, it is an enduser data entry error ;?
>> -//             DBG_WARNING(DbgInfo, "%s invalid; will be ignored\n", PARM_NAME_MICROWAVE_ROBUSTNESS);
>> +/*     } else {
>> +               this should not be debug time info, it is an enduser data entry error ;?
>> +               DBG_WARNING(DbgInfo, "%s invalid; will be ignored\n", PARM_NAME_MICROWAVE_ROBUSTNESS); */
> In such case you have lost the internal comments. I think it should look like
> /*
> } else {
> /* ... */

Sent a new patch. I tried the nested comments but gcc wont handle it
correctly (maybe I am wrong here). Please discard the old patch and
use this new one.

-//     } else {
-//             this should not be debug time info, it is an enduser
data entry error ;?
-//             DBG_WARNING(DbgInfo, "%s invalid; will be ignored\n",
PARM_NAME_MICROWAVE_ROBUSTNESS);
+       /* } else { */
+               /* this should not be debug time info, it is an
enduser data entry error ;? */
+               /* DBG_WARNING(DbgInfo, "%s invalid; will be
ignored\n", PARM_NAME_MICROWAVE_ROBUSTNESS); */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/