linux-kernel - Re: [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100510185729.GB19192@ghostprotocols.net>
Date:	Mon, 10 May 2010 15:57:29 -0300
From:	Arnaldo Carvalho de Melo <acme@...radead.org>
To:	Robert Richter <robert.richter@....com>
Cc:	Masami Hiramatsu <mhiramat@...hat.com>,
	Ingo Molnar <mingo@...e.hu>,
	lkml <linux-kernel@...r.kernel.org>,
	systemtap <systemtap@...rces.redhat.com>,
	Roland McGrath <roland@...hat.com>,
	DLE <dle-develop@...ts.sourceforge.net>
Subject: Re: [PATCH -tip] perf probe: Don't compile CFI related code if
 elfutils is old

Em Mon, May 10, 2010 at 08:36:54PM +0200, Robert Richter escreveu:
> On 10.05.10 13:28:54, Arnaldo Carvalho de Melo wrote:
> > Em Mon, May 10, 2010 at 01:12:07PM -0400, Masami Hiramatsu escreveu:
> > > Check elfutils version, and if it is old don't compile CFI
> > > analysis code. This allows to compile perf with old elfutils.

> > _ELFUTILS_PREREQ was introduced in:

> > commit fbc7245df72ce0142f0a21fa0f4f88c97278bf60
> > Author: Roland McGrath <roland@...hat.com>
> > Date:   Tue Dec 16 17:03:03 2008 -0800

> > Which was released in elfutils 0.138, guess this is coverage enough?
> > Richard, which version is in your machine?

> Right, this does not work, I am using 0.131. As expected,
> "_ELFUTILS_PREREQ" is not defined:

> util/probe-finder.h:47:5: error: "_ELFUTILS_PREREQ" is not defined
> util/probe-finder.h:47:21: error: missing binary operator before token "("
> make: *** [builtin-probe.o] Error 1

> Why not create a compile test as for NO_DWARF in tools/perf/Makefile?

Right, that would be better.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/