linux-kernel - Re: [PATCH] Check kmalloc return value before use the buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4BE883DB.1040504@tuxonice.net>
Date:	Tue, 11 May 2010 08:08:27 +1000
From:	Nigel Cunningham <nigel@...onice.net>
To:	Andy Isaacson <adi@...apodia.org>
CC:	Steven Liu <lingjiujianke@...il.com>,
	Linus WALLEIJ <linus.walleij@...ricsson.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Check kmalloc return value before use the buffer

Hi.

On 11/05/10 07:49, Andy Isaacson wrote:
> On Fri, May 07, 2010 at 03:17:39PM +0800, Steven Liu wrote:
>>   	bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
>> +	if (bigrxbuf_virtual == NULL) {
>> +		status = -ENOMEM;
>> +		kfree(bigtxbuf_virtual);
>> +		goto out;
>> +	}
>
> On Sat, May 08, 2010 at 11:27:09AM +1000, Nigel Cunningham wrote:
>>> Acked-by: Linus Walleij<linus.walleij@...ricsson.com>
>>
>> Acked-by: Nigel Cunningham<nigel@...onice.net>
>
> NACK.  Don't duplicate kfree(), instead do something like

Yeah... that is a better way of doing it.

Regards,

Nigel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/