linux-kernel - Re: linux-next: build failure after merge of the backlight tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201005100141.22985.vapier@gentoo.org>
Date:	Mon, 10 May 2010 01:41:21 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Richard Purdie <rpurdie@...ys.net>, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Michael Hennerich <michael.hennerich@...log.com>
Subject: Re: linux-next: build failure after merge of the backlight tree

On Sunday 09 May 2010 22:43:04 Stephen Rothwell wrote:
> After merging the backlight tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/video/backlight/adp8860_bl.c: In function 'adp8860_led_probe':
> drivers/video/backlight/adp8860_bl.c:215: error: implicit declaration of
> function 'kzalloc' drivers/video/backlight/adp8860_bl.c:215: warning:
> assignment makes pointer from integer without a cast
> drivers/video/backlight/adp8860_bl.c:285: error: implicit declaration of
> function 'kfree' drivers/video/backlight/adp8860_bl.c: In function
> 'adp8860_probe': drivers/video/backlight/adp8860_bl.c:673: warning:
> assignment makes pointer from integer without a cast
> drivers/video/backlight/adp8860_bl.c:689: error: too few arguments to
> function 'backlight_device_register'
> 
> Caused by commit 6f1a02240dba279a389fd4a4138445bd3f13f67f ("backlight:
> new driver for the ADP8860 backlight parts").  Use of kzalloc or kfree
> requires including linux/slab.h (see Rule 1 in
> Documentation/SubmitChecklist) and the prototype of
> backlight_device_register changed before v2.6.34-rc2.

obviously the driver simply missed the tree-wide slab.h updates

Richard: you want a new version to replace the one in your tree ?  or a one 
line fix for this issue ?
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)