linux-kernel - Re: [PATCH v2] cgroups: make cftype.unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 May 2010 15:26:44 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	"Kirill A. Shutemov" <kirill@...temov.name>, linux-mm@...ck.org,
	containers@...ts.linux-foundation.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Phil Carmody <ext-phil.2.carmody@...ia.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Daisuke Nishimura <nishimura@....nes.nec.co.jp>,
	Paul Menage <menage@...gle.com>,
	Li Zefan <lizf@...fujitsu.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cgroups: make cftype.unregister_event()
 void-returning

On Mon, 10 May 2010 15:08:15 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> wrote:

> On Sun,  9 May 2010 03:10:22 +0300
> "Kirill A. Shutemov" <kirill@...temov.name> wrote:
> 
> > Since we unable to handle error returned by cftype.unregister_event()
> > properly, let's make the callback void-returning.
> > 
> > mem_cgroup_unregister_event() has been rewritten to be "never fail"
> > function. On mem_cgroup_usage_register_event() we save old buffer
> > for thresholds array and reuse it in mem_cgroup_usage_unregister_event()
> > to avoid allocation.
> > 
> > Signed-off-by: Kirill A. Shutemov <kirill@...temov.name>
> 
> Hmm, just reusing buffer isn't enough ?
> as
> 	tmp = memory->thresholds;
> 	reduce entries on tmp
> And what happens when
> 
> 	register
> 	register
> 	register	
> 	unregister  (use preallocated buffer)
> 	unregister  ????
> 	unregister
> 
Ah, sorry my eyes were wrong.

The fix seems to work. 

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/