linux-kernel - Re: [PATCH 12/22] lmb: Add lmb_find_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1273472596.23699.37.camel@pasglop>
Date:	Mon, 10 May 2010 16:23:16 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 12/22] lmb: Add lmb_find_area_node()

On Sat, 2010-05-08 at 08:17 -0700, Yinghai Lu wrote:
> + * Need to call this function after lmb_register_active_regions,
> + * so early_node_map[] is filled already.
> + */

This is easily replaced by something simpler using my current WIP branch
and its nid allocator. IE, You don't need to add
find_memory_core_early(0 or any of that. It can be made a lot more
simply.

Cheers,
Ben.

> +u64 __init lmb_find_area_node(int nid, u64 start, u64 end, u64 size,
> u64 align)
> +{
> +       u64 addr;
> +       addr = find_memory_core_early(nid, size, align, start, end);
> +       if (addr != LMB_ERROR)
> +               return addr;
> +
> +       /* Fallback, should already have start end within node range
> */
> +       return lmb_find_area(start, end, size, align);
> +}
> + 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/