linux-kernel - Re: [PATCH] [OOPS] apbuart.c: Two problems related to grlib_apbuart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BE90339.8080304@gaisler.com>
Date:	Tue, 11 May 2010 09:11:53 +0200
From:	Kristoffer Glembo <kristoffer@...sler.com>
To:	Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] [OOPS] apbuart.c: Two problems related to 	grlib_apbuart_configure()

Miguel Ojeda wrote:
> On Sat, May 8, 2010 at 11:58 PM, Miguel Ojeda
> <miguel.ojeda.sandonis@...il.com> wrote:
>> Hi,
>>
>> I found two problems using the Simics' sunfire target, so maybe the
>> following does not occur in real machines.
>>
>> 1. At grlib_apbuart_configure() in apbuart.c, prop can be NULL if
>> "clock-frequency" doesn't exist in the OF tree:
>>
>>        /* Get bus frequency */
>>        rp = of_find_node_by_path("/");
>>        rp = of_get_next_child(rp, NULL);
>>        prop = of_get_property(rp, "clock-frequency", NULL);
>>        freq_khz = *prop;
>>
>> 2. In addition, apbuart.c does not check if there aren't any ports
>> configured after calls to grlib_apbuart_configure(), so other oops will
>> occur if no port was configured (e.g. uart_set_options() because of
>> port->ops).
>>
>> In order to solve that, I added a check after both of the calls to
>> grlib_apbuart_configure().
>>
>> The patch that I provide below prevents both problems in the Simics'
>> sunfire target.
>>
>> Tested against 2.6.33.3. Please review.
>>
>> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>


Thanks for the patch, it looks fine to me. 

Acked-by: Kristoffer Glembo <kristoffer@...sler.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/