lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4BE916CA.6030501@redhat.com>
Date:	Tue, 11 May 2010 11:35:22 +0300
From:	Avi Kivity <avi@...hat.com>
To:	Glauber Costa <glommer@...hat.com>
CC:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	zamsden@...hat.com
Subject: Re: [PATCH v3 0/8] pvclock fixes - v3

On 05/06/2010 12:27 AM, Glauber Costa wrote:
> Hello,
>
> Avi, this version fixes the issues you raised in the last
> review. Hopte it is better now.
>
>    

Sorry about the late review.  Looks reasonable, apart from a couple of 
minor points.

> A cpuid.txt wil follow as soon as we're set on everything, so
> I am not including it yet.
>    

Pity, for a reviewer it is a lot easier to review a spec, then the 
code's conformity to the spec, instead of having to reverse engineer the 
intent from the code.  Please include it next time.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ