linux-kernel - Re: [PATCH 10/10 -v3][RFC] tracing: Combine event filter_active and enable into single flags field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1273584628.22438.4501.camel@gandalf.stny.rr.com>
Date:	Tue, 11 May 2010 09:30:28 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Li Zefan <lizf@...fujitsu.com>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 10/10 -v3][RFC] tracing: Combine event filter_active
 and enable into single flags field

On Mon, 2010-05-10 at 23:30 -0400, Mathieu Desnoyers wrote:
> * Steven Rostedt (rostedt@...dmis.org) wrote:
> > From: Steven Rostedt <srostedt@...hat.com>
> > 
> > The filter_active and enable both use an int (4 bytes each) to
> > set a single flag. We can save 4 bytes per event by combining the
> > two into a single integer.
> > 

> I would also comment about flags read-side:
> 
>  * Flags are read concurrently without locking.

That can go in outside this patch set. As we discussed before, the
filter_active which does the same today as flags does here also has the
issue you are concerned with. IOW, this issue has nothing to do with
this patch set, because the issue existed before the patch set and has
not changed after the patch set.

The comment should also be in Documentation, not here, since it would
affect users more than the developers.

> 
> Besides that minor nit, the whole patchset has my
> 
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>

Thanks!  I'll get an official release ready.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/