linux-kernel - Re: [PATCH 2/6] swiotlb: swiotlb_tbl_map_single: abstract out swiotlb_virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100511105527Z.fujita.tomonori@lab.ntt.co.jp>
Date:	Tue, 11 May 2010 10:56:30 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	konrad.wilk@...cle.com
Cc:	fujita.tomonori@....ntt.co.jp, chrisw@...s-sol.org,
	jeremy@...p.org, albert_herranz@...oo.es,
	linux-kernel@...r.kernel.org, Ian.Campbell@...citrix.com,
	linux@...elenboom.it, iommu@...ts.linux-foundation.org,
	dwmw2@...radead.org, alex.williamson@...com
Subject: Re: [PATCH 2/6] swiotlb: swiotlb_tbl_map_single: abstract out
	swiotlb_virt_to_bus calls out.

On Mon, 10 May 2010 15:31:18 -0400
Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> wrote:

> On Sun, May 09, 2010 at 10:41:15PM +0900, FUJITA Tomonori wrote:
> > On Wed,  7 Apr 2010 16:29:26 -0400
> > Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> wrote:
> > 
> > > We want to move that function out of swiotlb_tbl_map_single so that the caller
> > > of this function does the virt->phys->bus address translation.
> > > 
> > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> > > ---
> > >  lib/swiotlb.c |   22 ++++++++++++++--------
> > >  1 files changed, 14 insertions(+), 8 deletions(-)
> > 
> > It would be better to do something like that instead of spreading
> > swiotlb_virt_to_bus()?
> 
> Yes! Thought I am confused by the name. In the past you mentioned 'tbl',
> but here it is 'tlb'. I presume 'tbl' is the right one?

Oops, yeah. I meant 'tbl' for 'table' since Calgary and POWERPC IOMMUs
use 'iommu_table' struct to store the global info.

Please replace 'tlb' with 'tbl'.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/