linux-kernel - Re: [PATCH 7/8] x86/mrst: add vrtc driver which serves as a wall clock device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100511103044.25fed8e7@feng-i7>
Date:	Tue, 11 May 2010 10:30:44 +0800
From:	Feng Tang <feng.tang@...el.com>
To:	"H. Peter Anvin" <hpa@...or.com>
CC:	Joe Perches <joe@...ches.com>, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Jacob Pan <jacob.jun.pan@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Ingo Molnar" <mingo@...e.hu>, "Du, Alek" <alek.du@...el.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 7/8] x86/mrst: add vrtc driver which serves as a wall
 clock device

On Tue, 11 May 2010 02:22:15 +0800
"H. Peter Anvin" <hpa@...or.com> wrote:

> On 05/10/2010 02:17 AM, Feng Tang wrote:
> > 
> > Thank you all for the comments. please review this follow-on patch.
> > 
> > - Feng
> 
> That doesn't move it to common code, though.  I'd rather see existing
> common style used, then merged (centralized) and *then* the style
> corrected.
> 
> 	-hpa

Hi Peter,

The reason I didn't move it to rtc common code is, this vrtc.c sits in
arch/x86/kernel/ and better not to depend on drivers/rtc, as drivers/rtc
may not be always enabled in kernel configuration.

I also have another general driver for vrtc which will be in drivers/rtc/,
just like general x86 kernel which has a rtc.c in arch/ and a rtc-cmos.c
in drivers/rtc, I will clean my code up and try to move these funcs to a
common code. 

Thanks,
Feng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/