linux-kernel - Re: [git pull request] ACPI patches for 2.6.34-rc6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100511172543.GA17868@srcf.ucam.org>
Date:	Tue, 11 May 2010 18:25:43 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Len Brown <lenb@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-acpi@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [git pull request] ACPI patches for 2.6.34-rc6

On Fri, May 07, 2010 at 10:36:00PM +0100, Matthew Garrett wrote:
> On Fri, May 07, 2010 at 02:21:08PM -0700, Linus Torvalds wrote:
> > Well, is there any reason to have 'set_sci_en_on_resume' at all then?
> 
> I'd hope not, but it depends on what Windows does on resume. If it 
> doesn't do the SMM call and just does the register write instead, then 
> it may be that some machines are on that list because the SMM call 
> breaks them rather than because they need the register to be set by 
> hand. I'm planning on instrumenting it to check, but haven't had time to 
> do so yet.

I've now checked the behaviour of Windows. It turns out that it never 
makes the ACPI enable SMM call on resume. This is consistent with 
http://bugzilla.kernel.org/show_bug.cgi?id=13745 which shows a bug 
being introduced by us making the enable call in the first place. 
Merging my patch and removing the blacklist would re-break these 
machines. Instead, we should just unconditionally set SCI_EN since this 
is the tested configuration. I'll send a followup patch.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/