linux-kernel - Re: [PATCH 5/6] swiotlb: Make swiotlb bookkeeping functions visible in the header file.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BE9A3BA.5090908@goop.org>
Date:	Tue, 11 May 2010 11:36:42 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Albert Herranz <albert_herranz@...oo.es>
CC:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	fujita.tomonori@....ntt.co.jp, linux-kernel@...r.kernel.org,
	iommu@...ts.linux-foundation.org, chrisw@...s-sol.org,
	Ian.Campbell@...citrix.com, dwmw2@...radead.org
Subject: Re: [PATCH 5/6] swiotlb: Make swiotlb bookkeeping functions visible
 in the header file.

On 05/11/2010 11:28 AM, Albert Herranz wrote:
> Konrad Rzeszutek Wilk wrote:
>   
>> +extern void *swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
>> +				    u64 tbl_dma_addr, size_t size,
>> +				    enum dma_data_direction dir);
>> +
>>     
> The phys and tbl_dma_addr arguments in the function prototype are swapped compared to the function definition in patch 1/6.
>   

Good catch.  I can see someone beating their head bloody over that...

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/