lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 11 May 2010 16:06:53 -0400
From:	Masami Hiramatsu <>
To:	Mathieu Desnoyers <>
CC:	Ingo Molnar <>, lkml <>,
	systemtap <>,
	DLE <>,
	Ananth N Mavinakayanahalli <>,
	Jim Keniston <>,
	Jason Baron <>
Subject: Re: [PATCH -tip 1/5] [CLEANUP] kprobes: Remove redundant	text_mutex
 lock in optimize

Hi Mathieu,

Mathieu Desnoyers wrote:
> * Masami Hiramatsu ( wrote:
>> Remove text_mutex locking in optimize_all_kprobes, because
>> that function doesn't modify text but just order optimization
>> to worker.
> Hi Masami,
> A few comments:
> 1) optimize_all_kprobes/unoptimize_all_kprobes should have comments saying that
> they are always called with kprobe_mutex held.
> 2) The sentence above in the changelog could be changed into:
>  ..."because this function doesn't modify text. It simply queues optimizations
> for the kprobe_optimizer worker thread."
> 3)
> static DEFINE_MUTEX(kprobe_mutex);      /* Protects kprobe_table */
> .. should also state that it protects optimizing_list.

Thanks! all comments are good to me!

Thank you again,

Masami Hiramatsu

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists