linux-kernel - Re: [107/117] ACPI: DMI init_set_sci_en_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100511033825.GA7513@canonical.com>
Date:	Mon, 10 May 2010 21:38:25 -0600
From:	Alex Chiang <achiang@...onical.com>
To:	Greg KH <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	stable-review@...nel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	Colin King <colin.king@...onical.com>,
	Len Brown <len.brown@...el.com>
Subject: Re: [107/117] ACPI: DMI init_set_sci_en_on_resume for multiple
 Lenovo ThinkPads

Hm, this patch looks a little wonky.

Why is every entry repeated 3x?

> +	.callback = init_set_sci_en_on_resume,
> +	.ident = "Lenovo ThinkPad T410",

[snip]

> +	.callback = init_set_sci_en_on_resume,
> +	.ident = "Lenovo ThinkPad T410",

[snip[

> +	.callback = init_set_sci_en_on_resume,
> +	.ident = "Lenovo ThinkPad T410",

Oh crap, it's broken upstream too. :(

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=patch;h=07bedca29b0973f36a6b6db36936deed367164ed

Not sure what happened, but I think some sort of hiccup occurred
when the patch was applied, since this is what hit the mailing
lists:

https://patchwork.kernel.org/patch/94711/

Len, Greg, what would you like me to do? I think the cleanest
thing to do to help keep -stable clean would be to:

	a) drop this patch from current -stable queue
	b) revert 07bedca29b09 upstream
	c) apply the patch from patchwork
	d) re-apply to -stable

Thoughts?

Thanks,
/ac
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/