linux-kernel - Re: [PATCH 21/25] lmb: Add "start" argument to lmb_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1273553786.21352.2.camel@pasglop>
Date:	Tue, 11 May 2010 14:56:26 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	tglx@...uxtronix.de, mingo@...e.hu, davem@...emloft.net,
	lethal@...ux-sh.org
Subject: Re: [PATCH 21/25] lmb: Add "start" argument to lmb_find_base()

On Mon, 2010-05-10 at 16:37 -0700, Yinghai Lu wrote:

> >                if (lmbsize < size)
> >                        continue;
> > -               base = min(lmbbase + lmbsize, max_addr);
> > -               res_base = lmb_find_region(lmbbase, base, size, align);
> > -               if (res_base != LMB_ERROR)
> > -                       return res_base;
> > +               if ((lmbbase + lmbsize) <= start)
> > +                       break;
> > +               bottom = max(lmbbase, start);
> > +               top = min(lmbbase + lmbsize, end);
> > +               if (bottom >= top)
> > +                       continue;
> > +               found = lmb_find_region(lmbbase, top, size, align);
>                                                                ^^^^^^^^^
> should use bottom  here

Correct, I missed that when converting.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/