linux-kernel - Re: [stable] cpumask: fix compat getaffinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100511151526.E578.A69D9226@jp.fujitsu.com>
Date:	Tue, 11 May 2010 15:20:45 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Greg KH <greg@...ah.com>
Cc:	kosaki.motohiro@...fujitsu.com,
	Rusty Russell <rusty@...tcorp.com.au>,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	Ken Werner <ken.werner@....de>,
	Andi Kleen <andi@...stfloor.org>, stable@...nel.org
Subject: Re: [stable] cpumask: fix compat getaffinity

> On Tue, May 11, 2010 at 10:47:03AM +0900, KOSAKI Motohiro wrote:
> > > How's this?
> > > 
> > > cpumask: use nr_cpu_ids for printing and parsing cpumasks
> > > 
> > > Commit a45185d2d "cpumask: convert kernel/compat.c" broke
> > > libnuma, which abuses sched_getaffinity to find out NR_CPUS
> > > in order to parse /sys/devices/system/node/node*/cpumap.
> > > 
> > > However, the result now returned reflects nr_cpu_ids, and
> > > cpumask_scnprintf et al. use nr_cpumask_bits which is NR_CPUS (for
> > > CONFIG_CPUMASK_OFFSTACK=n) or nr_cpu_ids (for
> > > CONFIG_CPUMASK_OFFSTACK=y).
> > > 
> > > We should use nr_cpu_ids consistently.
> > >
> > > Reported-by: Arnd Bergmann <arnd@...db.de>
> > > Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> > > Cc: stable@...nel.org
> > 
> > Well, This patch seems to have ABI change. please don't send abi-change to -stable.
> 
> Why?  There is no such thing as a "stable" internal abi in the kernel,
> and that includes the -stable kernel releases.
> 
> If it fixes a bug, that's all the requirement is.

AFAIK, -stable is mainly used for distro and they have many and many
packages. we can't assume no app read /sys files directly.
IOW, To change /sys printing format is a bit risky change. frequently
compatibility breaking natually break code stability.


> > note: I'm not against this patch itself.
> 
> Great, then it should be just fine, right?

Yup, fine.


Thanks.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/