lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 May 2010 07:36:22 -0500 From: Nishanth Menon <nm@...com> To: "eduardo.valentin@...ia.com" <eduardo.valentin@...ia.com> CC: LKML <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Linux-OMAP <linux-omap@...r.kernel.org>, Russell King <linux@....linux.org.uk>, Andrew Morton <akpm@...ux-foundation.org>, ext Tony Lindgren <tony@...mide.com>, ext Kevin Hilman <khilman@...prootsystems.com>, "De-Schrijver Peter (Nokia-D/Helsinki)" <Peter.De-Schrijver@...ia.com>, "Shilimkar, Santosh" <santosh.shilimkar@...com>, "K, Ambresh" <ambresh@...com>, "Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@...ia.com>, "Hogander Jouni (Nokia-D/Tampere)" <jouni.hogander@...ia.com>, Paul Mundt <lethal@...ux-sh.org> Subject: Re: [PATCHv5 2/3] OMAP: export OMAP info under /proc/socinfo Eduardo Valentin had written, on 05/12/2010 07:34 AM, the following: > Hello, > > On Tue, May 11, 2010 at 06:58:46PM +0200, Valentin Eduardo (Nokia-D/Helsinki) wrote: >> Hello Nishanth, >> >> On Tue, May 11, 2010 at 04:28:15PM +0200, ext Nishanth Menon wrote: >>> Eduardo Valentin had written, on 05/11/2010 09:15 AM, the following: >>>> From: Eduardo Valentin <eduardo.valentin@...ia.com> >>>> >>>> Export OMAP name and rev under /proc/socinfo node. >>>> >>>> Signed-off-by: Eduardo Valentin <eduardo.valentin@...ia.com> >>>> --- >>>> arch/arm/Kconfig | 1 + >>>> arch/arm/mach-omap1/id.c | 31 ++++++++++++++++++++++++------- >>>> arch/arm/mach-omap2/id.c | 32 ++++++++++++++++++++++++++------ >>>> 3 files changed, 51 insertions(+), 13 deletions(-) >>>> >>> [..] >>> >>>> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c >>>> index 37b8a1a..b67486b 100644 >>>> --- a/arch/arm/mach-omap2/id.c >>>> +++ b/arch/arm/mach-omap2/id.c >>> [..] >>> >>>> @@ -356,7 +363,8 @@ void __init omap3_cpuinfo(void) >>>> } >>>> >>>> /* Print verbose information */ >>>> - pr_info("%s ES%s (", cpu_name, cpu_rev); >>>> + snprintf(socinfo, SOCINFO_SZ, "%s ES%s", cpu_name, cpu_rev); >>>> + pr_info("%s (", socinfo); >>>> >>>> OMAP3_SHOW_FEATURE(l2cache); >>>> OMAP3_SHOW_FEATURE(iva); >>> Just a minor comment -> is it a good idea to pushin the features to SOC >>> info as well? currently this is being displayed at bootlog and not >>> beyond.. might be a better approach to move it into socinfo.. >> Yeah. I would expect that someone would ask this. When I was writing this part >> I also thought that would be nice to just duplicate all info which is printed >> into kernel log buffer. But then I decided to proceed with only the info we are >> needing from userspace. If you think that would be useful to know those as well, >> then why not adding them. > > As discussed in #linux-omap IRC channel, we agreed that it would be nice and useful > to export the OMAP FEATURES under this interface. But as the code to detect omap features is > under re-work currently, for now we are going to leave it out of this patch set. > Agreed. other than this, I dont see an issue :) thanks for the work.. Acked-by: Nishanth Menon <nm@...com> >>> >>> [..] >>> >>> -- >>> Regards, >>> Nishanth Menon >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@...r.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists