linux-kernel - Re: [PATCH] HID:magicmouse: This fixes a connection problem with the magicmouse.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87aas5i5ti.fsf@troilus.org>
Date:	Wed, 12 May 2010 09:54:17 -0400
From:	Michael Poole <mdpoole@...ilus.org>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	"Justin P. Mattock" <justinmattock@...il.com>,
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID:magicmouse: This fixes a connection problem with the magicmouse.

Jiri Kosina writes:

> On Wed, 12 May 2010, Justin P. Mattock wrote:
>
>> > > --- a/drivers/hid/hid-magicmouse.c
>> > > +++ b/drivers/hid/hid-magicmouse.c
>> > > @@ -354,7 +354,7 @@ static int magicmouse_probe(struct hid_device *hdev,
>> > >   		goto err_free;
>> > >   	}
>> > > 
>> > > -	ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT&  ~HID_CONNECT_HIDINPUT);
>> > > +	ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
>> > >      
>> > This is not particularly right, as we'll end up having dangling input
>> > device.
>> > 
>> > The problem is, that when HIDRAW is not set, hid_hw_start() returns ENODEV
>> > as no subsystem has claimed the device, and probe routine bails out. Which
>> > is not what we want.
>> > 
>> > Does the testing patch below fix the problems you are seeing?
>> > 
>> > 
>> >    
>> works good.. rebooted a few times mouse connects. suspended a few times 
>> mouse reconnects.
>
> I'd be glad if you could also double-check that device removal and 
> re-connecting it works well as well with this patch.
>
>> > diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
>> > index 0d471fc..f10d56a 100644
>> > --- a/drivers/hid/hid-magicmouse.c
>> > +++ b/drivers/hid/hid-magicmouse.c
>> > @@ -354,12 +354,15 @@ static int magicmouse_probe(struct hid_device *hdev,
>> >   		goto err_free;
>> >   	}
>> > 
>> > -	ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT&  ~HID_CONNECT_HIDINPUT);
>> > +	ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
>> >   	if (ret) {
>> >   		dev_err(&hdev->dev, "magicmouse hw start failed\n");
>> >   		goto err_free;
>> >   	}
>> > 
>> > +	/* we are handling the input ourselves */
>> > +	hidinput_disconnect(hdev);
>> > +
>> >   	report = hid_register_report(hdev, HID_INPUT_REPORT, TOUCH_REPORT_ID);
>> >   	if (!report) {
>> >   		dev_err(&hdev->dev, "unable to register touch report\n");
>> > 
>> >    
>> 
>> looks good over here.. If you'd like I can re-du this patch, add your 
>> sign off etc.. and re-send, or not worry.. either way this little 
>> quirk/problem is fixed.
>
> No problem, once you confirm that device removal wasn't broken again and 
> if I don't hear any objections from Michael, I will queue the patch 
> myself.

It looks good to me.  Thanks for doing this -- work has been busy this
week, so I haven't had time to dig into the issue yet.

Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/