linux-kernel - Re: [PATCH RFC tip/core/rcu 06/11] staging: remove all rcu head initializations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100512000821.GH2336@linux.vnet.ibm.com>
Date:	Tue, 11 May 2010 17:08:21 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Greg KH <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com,
	dipankar@...ibm.com, akpm@...ux-foundation.org,
	mathieu.desnoyers@...ymtl.ca, josh@...htriplett.org,
	dvhltc@...ibm.com, niv@...ibm.com, tglx@...utronix.de,
	peterz@...radead.org, rostedt@...dmis.org, Valdis.Kletnieks@...edu,
	dhowells@...hat.com, eric.dumazet@...il.com,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH RFC tip/core/rcu 06/11] staging: remove all rcu head
 initializations

On Tue, May 11, 2010 at 04:45:23PM -0700, Greg KH wrote:
> On Tue, May 11, 2010 at 04:33:01PM -0700, Paul E. McKenney wrote:
> > Remove all rcu head inits. We don't care about the RCU head state before passing
> > it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can
> > keep track of objects on stack.
> > 
> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> > Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> > Cc: Greg Kroah-Hartman <gregkh@...e.de>
> > ---
> >  drivers/staging/batman-adv/hard-interface.c |    1 -
> 
> Is this safe to apply to my tree now?  Or do you want to take it through
> your tree as it depends on other stuff?

Because the rcu_head in this case is not in an auto (on-stack) variable,
this commit is safe to apply to your tree now.

Let me know when you have applied it, and I will happily remove it
from mine.  ;-)

							Thanx, Paul

> If your tree, no objection from me, feel free to add:
> 	Acked-by: Greg Kroah-Hartman <gregkh@...e.de>
> 
> thanks,
> 
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/