linux-kernel - Re: [PATCH 2/8] [nmi watchdog] touch_softlockup cleanups and softlockup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 May 2010 23:00:36 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Don Zickus <dzickus@...hat.com>
Cc:	mingo@...e.hu, peterz@...radead.org, gorcunov@...il.com,
	aris@...hat.com, linux-kernel@...r.kernel.org,
	randy.dunlap@...cle.com
Subject: Re: [PATCH 2/8] [nmi watchdog] touch_softlockup cleanups and
	softlockup_tick removal

On Wed, May 12, 2010 at 04:56:16PM -0400, Don Zickus wrote:
> On Wed, May 12, 2010 at 10:28:35PM +0200, Frederic Weisbecker wrote:
> > On Wed, May 12, 2010 at 04:26:28PM -0400, Don Zickus wrote:
> > > On Wed, May 12, 2010 at 10:06:54PM +0200, Frederic Weisbecker wrote:
> > > > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> > > > > index 1083897..1fec781 100644
> > > > > --- a/kernel/sysctl.c
> > > > > +++ b/kernel/sysctl.c
> > > > > @@ -827,15 +827,6 @@ static struct ctl_table kern_table[] = {
> > > > >  		.extra1		= &zero,
> > > > >  		.extra2		= &one,
> > > > >  	},
> > > > > -	{
> > > > > -		.procname	= "softlockup_thresh",
> > > > > -		.data		= &softlockup_thresh,
> > > > > -		.maxlen		= sizeof(int),
> > > > > -		.mode		= 0644,
> > > > > -		.proc_handler	= proc_dosoftlockup_thresh,
> > > > > -		.extra1		= &neg_one,
> > > > > -		.extra2		= &sixty,
> > > > > -	},
> > > > 
> > > > 
> > > > 
> > > > I wonder about the ABI breakage.
> > > > 
> > > > But I suspect few userspace tools use it though, since this is
> > > > mostly for kernel dev.
> > > 
> > > There is no breakage, this chunk of code was duplicated later in the file.
> > > I am just removing the duplicated bits to simplify the SOFTLOCKUP Kconfig
> > > stuff.
> > > 
> > > Cheers,
> > > Don
> > 
> > 
> > Ah right.
> > 
> > BTW, if you address my reviews, please do it incrementally, I'm going
> > to apply this set and push it to Ingo.
> 
> Ok, probably easier to review too. :-)


Yeah, and it's time to flush this code as it's good globally.

Plus it would be nice to get this for .35

Ah and forget about the sysctl ABI breakages. Since this is only
used for kernel development, this is not going to break much things.
If somebody complains, we can still reintegrate what we had.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/