linux-kernel - [RFC] new ->perform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100512212403.GE3597@localhost.localdomain>
Date:	Wed, 12 May 2010 17:24:04 -0400
From:	Josef Bacik <josef@...hat.com>
To:	linux-fsdevel@...r.kernel.org
Cc:	chris.mason@...cle.com, hch@...radead.org,
	akpm@...ux-foundation.org, npiggin@...e.de,
	linux-kernel@...r.kernel.org
Subject: [RFC] new ->perform_write fop

Hello,

I just started adding aio_write to Btrfs and I noticed we're duplicating _alot_
of the generic stuff in mm/filemap.c, even though the only thing thats really
unique is the fact that we copy userspace pages in chunks rather than one page a
t a time.  What would be best is instead of doing write_begin/write_end with
Btrfs, it would be nice if we could just do our own perform_write instead of
generic_perform_write.  This way we can drop all of these generic checks we have
that we copied from filemap.c and just got to the business of actually writing
the data.  I hate to add another file operation, but it would _greatly_ reduce
the amount of duplicate code we have.  If there is no violent objection to this
I can put something together quickly for review.  Thanks,

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/