linux-kernel - Re: [PATCH] USB: gadget: f_mass_storage: fix in error recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 13 May 2010 00:16:00 +0200
From:	Michal Nazarewicz <mina86@...a86.com>
To:	Greg KH <greg@...ah.com>
Cc:	Michal Nazarewicz <m.nazarewicz@...sung.com>,
	linux-usb@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Viral Mehta <Viral.Mehta@...infotech.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: gadget: f_mass_storage: fix in error recovery

> On Wed, May 12, 2010 at 12:51:13PM +0200, Michal Nazarewicz wrote:
>> In to places in fsg_common_init() an unconditional call to kfree()
>> on common was performed in error recovery which is not a valid
>> behaviour since fsg_common structure is not always allocated by
>> fsg_common_init().
>> 
>> To fix, the calls has been replaced with a goto to a proper error
>> recovery which does the correct thing.
>> 
>> Also, refactored fsg_common_release() function.
>> 
>> Signed-off-by: Michal Nazarewicz <mina86@...a86.com>

Greg KH <greg@...ah.com> writes:
> Does this superseed your previous patch in this thread?

Yes. 

The difference is with fsg_common_release() function which is
purely a style change.

-- 
Best regards,                                         _     _
 .o. | Liege of Serenly Enlightened Majesty of      o' \,=./ `o
 ..o | Computer Science,  Michal "mina86" Nazarewicz   (o o)
 ooo +--<mina86-tlen.pl>--<jid:mina86-jabber.org>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/