linux-kernel - Re: [PATCH] fix hard-coded disk header chunk size for persistent snapshot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1005120055020.1551@hs20-bc2-1.build.redhat.com>
Date:	Wed, 12 May 2010 00:58:27 -0400 (EDT)
From:	Mikulas Patocka <mpatocka@...hat.com>
To:	Alasdair G Kergon <agk@...hat.com>
cc:	Tomohiro Kusumi <kusumi.tomohiro@...fujitsu.com>,
	dm-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix hard-coded disk header chunk size for persistent
 snapshot



On Wed, 12 May 2010, Alasdair G Kergon wrote:

> On Wed, May 12, 2010 at 10:29:22AM +0900, Tomohiro Kusumi wrote:
> > This patch fixes hard-coded value for the size of a chunk that includes
> > disk header for persistent snapshot. It should be changed to existing
> > macro NUM_SNAPSHOT_HDR_CHUNKS instead of using hard-coded value 1.
>  
> Any more places too?  (E.g. persistent_commit_merge)
> 
> Alasdair

I think the expression in persistent_commit_merge should be changed to:
ps->next_free = area_location(ps, ps->current_area) +
                ps->current_committed + 1;

It is numerically the same, but will avoid trouble if 
NUM_SNAPSHOT_HDR_CHUNKS is increased.

Mikulas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/