linux-kernel - [tip:x86/fpu] x86, fpu: Use the proper asm constraint in use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-dce8bf4e115aa44d590802ce3554e926840c9042@git.kernel.org>
Date:	Wed, 12 May 2010 00:18:44 GMT
From:	"tip-bot for H. Peter Anvin" <hpa@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	suresh.b.siddha@...el.com, tglx@...utronix.de, avi@...hat.com
Subject: [tip:x86/fpu] x86, fpu: Use the proper asm constraint in use_xsave()

Commit-ID:  dce8bf4e115aa44d590802ce3554e926840c9042
Gitweb:     http://git.kernel.org/tip/dce8bf4e115aa44d590802ce3554e926840c9042
Author:     H. Peter Anvin <hpa@...or.com>
AuthorDate: Mon, 10 May 2010 13:41:41 -0700
Committer:  H. Peter Anvin <hpa@...or.com>
CommitDate: Mon, 10 May 2010 13:41:41 -0700

x86, fpu: Use the proper asm constraint in use_xsave()

The proper constraint for a receiving 8-bit variable is "=qm", not
"=g" which equals "=rim"; even though the "i" will never match, bugs
can and do happen due to the difference between "q" and "r".

Signed-off-by: H. Peter Anvin <hpa@...or.com>
Cc: Avi Kivity <avi@...hat.com>
Cc: Suresh Siddha <suresh.b.siddha@...el.com>
LKML-Reference: <1273135546-29690-2-git-send-email-avi@...hat.com>
---
 arch/x86/include/asm/i387.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/i387.h b/arch/x86/include/asm/i387.h
index 1a8cca3..8002e9c 100644
--- a/arch/x86/include/asm/i387.h
+++ b/arch/x86/include/asm/i387.h
@@ -64,7 +64,7 @@ static inline bool use_xsave(void)
 	alternative_io("mov $0, %0",
 		       "mov $1, %0",
 		       X86_FEATURE_XSAVE,
-		       "=g"(has_xsave));
+		       "=qm" (has_xsave));
 
 	return has_xsave;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/