linux-kernel - Re: [PATCH 2/2] Staging: comedi: Fixed more long line lengths in comedi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 May 2010 03:40:32 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mark <reodge@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, Bernd Porr <berndporr@....com>,
	Gorskin Ilya <revent82@...il.com>
Subject: Re: [PATCH 2/2] Staging: comedi: Fixed more long line lengths in
 comedi.h

On Thu, 2010-05-13 at 18:28 +0800, Mark wrote:
> I'd like to get some feedback on this patch, since I'm not sure this is the best
> way to fix the long line lengths. 
> ---
>  drivers/staging/comedi/comedi.h |   15 ++++++++++-----
>  1 files changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
> index 3e3663f..ea96a83 100644
> --- a/drivers/staging/comedi/comedi.h
> +++ b/drivers/staging/comedi/comedi.h
> @@ -267,7 +267,8 @@
>  		 * streaming input/output */
>  		INSN_CONFIG_GET_HARDWARE_BUFFER_SIZE = 2006,
>  		INSN_CONFIG_SET_COUNTER_MODE = 4097,
> -		INSN_CONFIG_8254_SET_MODE = INSN_CONFIG_SET_COUNTER_MODE,	/* deprecated */
> +		/* deprecated */

			/* INSN_CONFIG_8254_SET_MODE is deprecated */

[]

> -	static inline unsigned NI_CDIO_SCAN_BEGIN_SRC_RTSI(unsigned rtsi_channel)
> +	static inline unsigned
> +		NI_CDIO_SCAN_BEGIN_SRC_RTSI(unsigned rtsi_channel)
>  	{
>  		return NI_USUAL_RTSI_SELECT(rtsi_channel);
>  	}

It'd be better to start the functions in column 1

static inline unsigned int NI_CDIO_SCAN_BEGIN_RTSI(unsigned int rtsi_channel)
{
	return NI_USUAL_RTSI_SELECT(rtsi_channel);
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/