linux-kernel - Re: [patch] libsas: dereferencing variable before check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23e0bf65-8758-45b3-b0a8-1df97db07d9a@email.android.com>
Date:	Thu, 13 May 2010 01:08:05 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Dan Carpenter <error27@...il.com>,
	"James E.J. Bottomley" <James.Bottomley@...e.de>
CC:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch] libsas: dereferencing variable before check



"Dan Carpenter" <error27@...il.com> wrote:

>The "qc->scsicmd" could be null so I moved the dereference inside the
>check.  This was introduced by 70b25f890: "[SCSI] fix locking around
>blk_abort_request()" 
>
>Signed-off-by: Dan Carpenter <error27@...il.com>

Ooh.. right.

Asked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/