lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 May 2010 19:11:25 +0800 From: Changli Gao <xiaosuo@...il.com> To: akpm@...ux-foundation.org Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Changli Gao <xiaosuo@...il.com> Subject: [PATCH 7/9] cxgb4: use kvzalloc and kvfree use kvzalloc and kvfree use kvzalloc and kvfree Signed-off-by: Changli Gao <xiaosuo@...il.com> ---- drivers/net/cxgb4/cxgb4.h | 3 --- drivers/net/cxgb4/cxgb4_main.c | 37 +++++-------------------------------- drivers/net/cxgb4/l2t.c | 2 +- 3 files changed, 6 insertions(+), 36 deletions(-) diff --git a/drivers/net/cxgb4/cxgb4.h b/drivers/net/cxgb4/cxgb4.h index 8856a75..2a38fad 100644 --- a/drivers/net/cxgb4/cxgb4.h +++ b/drivers/net/cxgb4/cxgb4.h @@ -584,9 +584,6 @@ static inline struct adapter *netdev2adap(const struct net_device *dev) void t4_os_portmod_changed(const struct adapter *adap, int port_id); void t4_os_link_changed(struct adapter *adap, int port_id, int link_stat); -void *t4_alloc_mem(size_t size); -void t4_free_mem(void *addr); - void t4_free_sge_resources(struct adapter *adap); irq_handler_t t4_intr_handler(struct adapter *adap); netdev_tx_t t4_eth_xmit(struct sk_buff *skb, struct net_device *dev); diff --git a/drivers/net/cxgb4/cxgb4_main.c b/drivers/net/cxgb4/cxgb4_main.c index 1bad500..776f72f 100644 --- a/drivers/net/cxgb4/cxgb4_main.c +++ b/drivers/net/cxgb4/cxgb4_main.c @@ -55,7 +55,6 @@ #include <linux/sched.h> #include <linux/seq_file.h> #include <linux/sockios.h> -#include <linux/vmalloc.h> #include <linux/workqueue.h> #include <net/neighbour.h> #include <net/netevent.h> @@ -742,32 +741,6 @@ out: release_firmware(fw); return ret; } -/* - * Allocate a chunk of memory using kmalloc or, if that fails, vmalloc. - * The allocated memory is cleared. - */ -void *t4_alloc_mem(size_t size) -{ - void *p = kmalloc(size, GFP_KERNEL); - - if (!p) - p = vmalloc(size); - if (p) - memset(p, 0, size); - return p; -} - -/* - * Free memory allocated through alloc_mem(). - */ -void t4_free_mem(void *addr) -{ - if (is_vmalloc_addr(addr)) - vfree(addr); - else - kfree(addr); -} - static inline int is_offload(const struct adapter *adap) { return adap->params.offload; @@ -2034,7 +2007,7 @@ static int tid_init(struct tid_info *t) size = t->ntids * sizeof(*t->tid_tab) + natids * sizeof(*t->atid_tab) + t->nstids * sizeof(*t->stid_tab) + BITS_TO_LONGS(t->nstids) * sizeof(long); - t->tid_tab = t4_alloc_mem(size); + t->tid_tab = kvzalloc(size); if (!t->tid_tab) return -ENOMEM; @@ -3308,8 +3281,8 @@ sriov: return 0; out_free_dev: - t4_free_mem(adapter->tids.tid_tab); - t4_free_mem(adapter->l2t); + kvfree(adapter->tids.tid_tab); + kvfree(adapter->l2t); for_each_port(adapter, i) if (adapter->port[i]) free_netdev(adapter->port[i]); @@ -3349,8 +3322,8 @@ static void __devexit remove_one(struct pci_dev *pdev) t4_sge_stop(adapter); t4_free_sge_resources(adapter); - t4_free_mem(adapter->l2t); - t4_free_mem(adapter->tids.tid_tab); + kvfree(adapter->l2t); + kvfree(adapter->tids.tid_tab); disable_msi(adapter); for_each_port(adapter, i) diff --git a/drivers/net/cxgb4/l2t.c b/drivers/net/cxgb4/l2t.c index 9f96724..f975087 100644 --- a/drivers/net/cxgb4/l2t.c +++ b/drivers/net/cxgb4/l2t.c @@ -513,7 +513,7 @@ struct l2t_data *t4_init_l2t(void) int i; struct l2t_data *d; - d = t4_alloc_mem(sizeof(*d)); + d = kvzalloc(sizeof(*d)); if (!d) return NULL; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists